feat: automatically derive the the dependent resource type if not specified #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cified Signed-off-by: xstefank <[email protected]>
csviri
reviewed
Apr 16, 2025
|
I think we had something similar to this at some point but decided to make it explicit because there were too many cases where the automatic resolution of the type was causing issues (iirc). Having a no-arg constructor might induce people to initialize their dependent resources with it and then get weird exceptions when the automatic resolution fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changing the samples for now. Let me know what you think and I can change all resources or even deprecate some other ctors.